Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate color for syntax elements and comments #29

Closed
matze opened this issue Oct 12, 2021 · 4 comments
Closed

Use separate color for syntax elements and comments #29

matze opened this issue Oct 12, 2021 · 4 comments
Labels

Comments

@matze
Copy link
Contributor

matze commented Oct 12, 2021

At the moment the color scheme uses the same color as for comments which is also used for inlay hints. This makes longer combinator chains in Rust really hard to read:

example

Ideally there would be separate colors for syntactical elements and comments to better differentiate them.

@matze matze changed the title Use separate color for braces/parentheses/brackets/dots and comments Use separate color for syntax elements and comments Oct 12, 2021
@mvllow
Copy link
Member

mvllow commented Oct 12, 2021

Hmm, I don't use inlay hints but looking at this example https://github.com/simrat39/rust-tools.nvim#expand-macros-recursively it appears Dracula is also using the same colour for both comments and inlay hints. After browsing Dracula's code I don't see them setting anything specific for the inlay hints so I'm not sure if that's changeable, unfortunately.

If you do end up finding a highlight group for only the inlay hints I'll be happy to revisit making them different colours 😌

@matze
Copy link
Contributor Author

matze commented Oct 12, 2021

And I suppose, not using comment color for syntax elements like parentheses, dots etc. is out of question?

mvllow added a commit that referenced this issue Oct 12, 2021
@mvllow
Copy link
Member

mvllow commented Oct 12, 2021

I went ahead and made some colours overridable via vim.g.rose_pine_colors. A full example can be found in the readme.

Hope this helps!

@matze
Copy link
Contributor Author

matze commented Oct 12, 2021

Hope this helps!

Absolutely! Thanks for the quick response and great theme.

@matze matze closed this as completed Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants