Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Update rosjava_bootstrap and all messges #36

Merged
merged 3 commits into from
May 10, 2017

Conversation

adamantivm
Copy link
Contributor

This is a general update of rosjava messages after the fix that @jubeira did for genjava here.

This should resolve the conflict with old versions of message_generation when using rosjava kinetic.

@jubeira @ernestmc could you please review carefully and help me think through if this is OK and won't cause an inverse problem for people trying to build with older (indigo) versions of rosjava artifacts?

@ernestmc
Copy link
Member

lgtm
It's good that this equalizes the version dependency of the messages. I don't expect any problems to arise for the users. Anyway, Indigo users are expected to use the older version of the messages, which have not changed.

Copy link

@jubeira jubeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM! I Agree with @ernestmc , this should't cause issues.

@adamantivm adamantivm merged commit bb815ea into rosjava:master May 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants