-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Popup content shifted up in 1.1.0-pre2 #142
Comments
@MichaelRumpler Give me your xaml code which you use in PopupPage please. |
I added a repro page to https://github.com/MichaelRumpler/Rg.Plugins.Popup/tree/Repro_142 It's the complete page just to be sure. |
@MichaelRumpler Thank you for examples. I will look it soon. |
Any update about this? Thanks |
@shineon84 I will work on it soon. |
I updated my branch https://github.com/MichaelRumpler/Rg.Plugins.Popup/tree/Repro_142 to the current master. This represents Rg.Plugins.Popup 1.1.4 and uses Xamarin.Forms 3.0. It still has the same problem. |
@MichaelRumpler I have reviewed this issue and I can say that it is not popup's problem. Xamrin.Forms contains special class KeyboardInsetTracker which changes |
I'm ok with a workaround. Until now I just sticked with version 1.1.0-pre1, but I switched my PCL to .NET Standard now and that complains when I want to install that old version. |
@MichaelRumpler try to use v1.1.5.180 and to set |
@MichaelRumpler You need to keep all elements inside ScrollView, and set VerticalOptions=Fill for ScrollView and Center for Content of ScrollView |
This makes the popup full height even without keyboard. I updated the repro in https://github.com/MichaelRumpler/Rg.Plugins.Popup/blob/Repro_142/src/Demo/Demo/Pages/ReproPage.xaml#L81 |
@MichaelRumpler You set P.S. if you remove |
This is funny! Any reason why this caused problems? Many thanks, now everything works as it should. Let me know if you come to Vienna/Austria. I owe you something. |
@MichaelRumpler You are welcome. It happens because of |
Yes, but why does it change when I move the |
@MichaelRumpler Because |
When I updated from 1.1.0-pre1 to 1.1.0-pre2, the content of my popup was shifted up.
This is how it looked in pre1:
![1 1 0-pre1](https://user-images.githubusercontent.com/8309363/27476045-8b9ed29c-5807-11e7-9ece-dba00c4de28d.jpg)
And in pre2 it is too far up:
![1 1 0-pre2](https://user-images.githubusercontent.com/8309363/27476067-9b542c0a-5807-11e7-99b3-38d67b019bcf.jpg)
I'm trying this on an iPad Pro with iOS 10.3.2. The popup does not use any animation.
The Label gets the focus on appearing. If I close the keyboard, then the contents are shown at the correct position, but when I set the focus to the Label to show the keyboard again, the content will be shifted up once more.
I tried setting SystemPadding, but that had no effect. Setting HasSystemPadding="false" did not shift the popup up when the keyboard was opened.
The text was updated successfully, but these errors were encountered: