Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Fix executing hooks with different prototypes #1

Closed
wants to merge 1 commit into from
Closed

Fix executing hooks with different prototypes #1

wants to merge 1 commit into from

Conversation

M66B
Copy link
Contributor

@M66B M66B commented Jun 5, 2013

Note: performance penalty unknown

Note: performance penalty unknown
@rovo89
Copy link
Owner

rovo89 commented Jun 5, 2013

Thanks! That should work. For performance reasons, I would compare the class before the prototype, but the should only be only a minimal difference.
I leave this open for now as I probably have to move around a couple of things for performance improvements, which could make the function in its current form unnecessary. But I will definitely keep this in mind during my changes.

@M66B
Copy link
Contributor Author

M66B commented Jun 5, 2013

I always test before I do a pull request, so yes it works ;-) I use it for my own project XPrivacy.

@rovo89 rovo89 mentioned this pull request Jul 27, 2013
@rovo89
Copy link
Owner

rovo89 commented Aug 24, 2013

Merged in 2704987.

As mentioned above I moved comparison of the prototype behind the comparison of the class name, as it can be a bit more complicated than a simple string comparison. Anyway, that shouldn't matter much.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants