-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Conversation
Wow. Are all features already working (normal hooks, resource replacement)? That looks like a great effort you have done so far. Still I have mixed feelings about it. If I understand your commits correctly, both the native and the Java part need hacks in the AOSP code. Is this only needed for compiling? If yes, it still makes it even harder to compile Xposed. If the ROM needs to be patched as well, it's hardly possible to distribute it widely. If there is any way to make it work without the hacks, that would be great. The aspects that I worry about most however are that all those conditions make the code harder to understand and maintain. Any additions or changes need to consider Gingerbread support. I don't have any GB device, the emulator is awfully slow and again this adds a lot of complexity to the code (which of course takes time away from other things). The same things also apply to modules. Not sure if there need to be interface changes, but they would need to use conditions if they want to work across different versions. Finally, I'm currently rewriting many parts of the installer. It would need another big rewrite to use the support library for fragments etc. You see, backwards compatibility can really become a PITA. So I'm wondering if this should really be merged into the original project at this time or stay as a fork. I'd like to hear what @Tungstwenty thinks about this, but maybe it could start as an experimental version, published and maintained by yourself. If it is adopted well, changes/fixes could either be exchanged between the two repositories/branches, or we can then talk again about merging the code and adding you as additional maintainer for all Gingerbread-related stuff. |
Rovo89, Thanks for your great work on app_process, and all the work on xposed. Shortly, I have tested for the framework on gingerbread (motorola xprt), According the author of xprivacy, they said "Because of a bug in the Xposed Best regards, 2013/7/28 rovo89 notifications@github.com
|
The fix is pull request #1. I will merge it before the next version. |
I am happy that Liu took the time to investigate and work on this and get the core of the framework working on GB. |
I just checked the pull request for the XposedBridge. |
for the c++ version xposed, as we actually compile for different platform, for the java xposed bridge, we should use modified framework api 10 or api For override annotation, this is used for java, not dalvik, i compare the As sdk 10 is still 30+%, the top sdk
|
note: the framework patch is to generated full_framework_sdk10.jar, the for replace private to public, i think rovo89 do so too, just to avoid for other added method, just for java compile, as we using @OverRide, this
|
@Tungstwenty for change private to public, its a bug in gcc, not in vc. just check for following code: /* private.cpp */ /* main.cpp */ yes, you can visit private method in private.cpp or private.o, or some dll/so/dylib. for the second java private method access, please see @rovo89 's code in xposed.cpp/xposedtest.cpp |
Of course I know what that code does. I have written it myself. But what's your point? What do you want do show? The fact is that the current code doesn't require any changes to the AOSP code. The full-framework15.jar file is unmodified code, just with the hidden code (@hide) included. |
i modified code, just make XposedBridge to compile. following is added dummy function: getStringSet(String key, Set defValues) updateConfiguration(Configuration config, DisplayMetrics metrics, CompatibilityInfo compat) getDrawableForDensity(int id, int density) all in short, add dummy code for xposedbridge to be compiled for api10 and api15. |
It sounds to me like all the Java changes would not be necessary if XposedBridge.jar was compiled with the SDK15 framework where those methods exist. There is no version check for the jar file. The override for missing methods is not very clean, but ok... I'm more worried about the dalvik.c.patch. Why is this needed? It means that compiling Xposed is not limited to the folder you check out to, but affects also the source tree, making it even more complicated to compile Xposed. There has to be an alternative for this. Anyway, before digging deeper into technical details, let's talk about some not so technical stuff first. Some things need to be clear:
So far, I haven't seen much feedback about your version at XDA. I'm wondering whether a separate thread for GB support wouldn't be better, I think everyone would benefit. You could keep track of any questions more easily, users would find answers specific to GB instead of Android 4.3, it's more visible and I don't have to care about it. It would also make it easier to estimate how many people actually tried it and how stable it is. In order to make it more attractive, I think it would help if you made a few more existing modules compatible with GB, ask the developers if they are willing to do so or develop some yourself. |
yes, there is no any benefit to support gingerbread. thanks for your support. for dalvik.c.patch, its just because the xposed is written in c++, and dalvik before android 4.0 is written in c. |
Conflicts: app_main.cpp
If it had it's own thread and some working modules then I think it'd do a little better. It doesn't help that the ported version of XPrivacy is kind of slow and buggy on my device, so that's not a great way to show off what Xposed can do. This port is great, but I think the problem is that most people with Gingerbread can install a version of CyanogenMod. That or they've used baksmali/smali and have got custom ROM's containing all of the features they want already. Anyone that's wanted more than that has upgraded to a newer device, so there's not going to be much support from anyone. Heck, even normal apps are starting to drop API 10 support. |
@blackbox87 yes, i think you guys are right. however, i will keep porting, because newer devices are so huge to me, and without physical keyboard. the latest xprivacy (i even didnt push to github), which i havnt release yet, works well on my device. i will release new versions of xposed/xposed installer/xprivacy using another name, about in this weekend. |
No description provided.