Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make recipes work "in the background" #201

Merged
merged 55 commits into from
Sep 9, 2023
Merged

Make recipes work "in the background" #201

merged 55 commits into from
Sep 9, 2023

Conversation

rozPierog
Copy link
Owner

@rozPierog rozPierog commented Jul 25, 2023 •
edited
Loading

Description

Moves timer to the notification when app stops being visible

Fixes #200 #64 #147

Type of change

  • Bug fix
  • New feature

Checklist:

  • I've added new item into Changelog under [Unreleased]
  • I've tested the change on device

TODO:

  • Only show notification when app is in the background
  • multipliers
  • open the app with recipe on press
  • Test WearOS
  • Adjust Notification UI
  • Add Notification Permission request
  • Add setting to disable this behavior
  • Clean up code

@rozPierog rozPierog self-assigned this Jul 25, 2023
@rozPierog rozPierog mentioned this pull request Jul 29, 2023
Closed
@rozPierog
Save time when timer went into background and get it back when app co…
43b18bd 
…mes back
@rozPierog
Use saved time to calculate what step should be now
3e3b6a3
@rozPierog
Merge branch 'main' into notification2
bb9faa1 
# Conflicts:
#	cofi-share/src/main/java/com/omelan/cofi/share/timer/Timer.kt
@rozPierog
Start notification timer and app timer at the same time to sync start…
25d4d40 
… marker
@rozPierog
Stop notification if step needs userinput
c5ab7ed
@rozPierog
kinda working stopping of the notification timer
ba6233d
@rozPierog
Reimplement count down in notification so that it blocks worker till …
76aeed3 
…it's done
@rozPierog
Synchronize state between notification and ComposeUI
5d47003
@rozPierog
Cleanup code smell from previous attempts
aa70495
@rozPierog
Cleanup passing data back and forth
442f907
@rozPierog
Allow for multiple timers at once, and restore progress even without …
6307db4 
…UUID
@rozPierog
pass recipe to createTimerControllers
26c8b6f
@rozPierog
Only update progress is worker is running
aa78408
@rozPierog
Working on actions in the notification
77215ae
@rozPierog
Start stop notification timer from the app
d4cde8b
@rozPierog
Fix not updating pending intent
37485b9
@rozPierog
Properly calculate progress of the notification on resume
7febd22
@rozPierog
Update service on changing step
19d8b23
@rozPierog
Stop and clear notification
864fedc
@rozPierog
remove useless code
347f4cf
@rozPierog
Only show notification when current recipe isn't already on the screen
d99eed9
@rozPierog
Add more info to timer notification
3d3b3c3
@rozPierog
Add multiplier support to notification timer
d1a01c6
@rozPierog
Cleanup
e8e4c43
@rozPierog rozPierog marked this pull request as ready for review September 3, 2023 14:07
@rozPierog
Copy link
Owner Author

rozPierog commented Sep 3, 2023 •
edited
Loading

Issues from testing:

  • no vibration on notification
  • notification from a phone not showing up on WearOS

rozPierog
rozPierog commented Sep 9, 2023
View reviewed changes
Copy link
Owner Author

@rozPierog rozPierog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work me
image

@rozPierog rozPierog merged commit 8d274f5 into main Sep 9, 2023
2 of 3 checks passed
@rozPierog rozPierog deleted the notification2 branch September 9, 2023 17:50
This was referenced Sep 9, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rozPierog rozPierog

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notification for recipes' steps
1 participant
@rozPierog