Skip to content

Fix AsynchronousTlsChannelGroup closing #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix AsynchronousTlsChannelGroup closing #385

wants to merge 1 commit into from

Conversation

rozza
Copy link
Owner

@rozza rozza commented May 26, 2020 •
edited
Loading

Built upon Jeffs J3696 this little bug nearly broke me!
https://evergreen.mongodb.com/version/5ecd0f853627e07ed81bfcad

JAVA-3730

@rozza rozza requested review from jstewart148 and jyemin May 26, 2020 13:03
jyemin
jyemin approved these changes May 27, 2020
View reviewed changes
Copy link
Collaborator

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's commit this on master once we hear from Mariano (or get tired of waiting for him) and I'll rebase on top of it and remove all the concurrentClose business.

@rozza rozza closed this May 28, 2020
@rozza rozza deleted the j3730 branch May 28, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jyemin jyemin jyemin approved these changes

@jstewart148 jstewart148 Awaiting requested review from jstewart148

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rozza @jyemin