Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Future Incompat warning #213

Closed
Skgland opened this issue Mar 13, 2023 · 3 comments · Fixed by #219
Closed

Future Incompat warning #213

Skgland opened this issue Mar 13, 2023 · 3 comments · Fixed by #219
Labels
dependencies Pull requests that update a dependency file

Comments

@Skgland
Copy link
Contributor

Skgland commented Mar 13, 2023 •
edited 

warning: the following packages contain code that will be rejected by a future version of Rust: buf_redux v0.8.4, nom v4.2.3
note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 103`
$ cargo tree -i nom@4.2.3
nom v4.2.3
└── pgp v0.9.0

$ cargo tree -i buf_redux
buf_redux v0.8.4
└── pgp v0.9.0
@link2xt
Copy link
Contributor

link2xt commented Mar 13, 2023

There is an unfinished nom upgrade PR #140.

@Skgland
Copy link
Contributor Author

Skgland commented Mar 16, 2023

I opened #214 for the nom part, though I still need to perform some cleanup.

@dignifiedquire dignifiedquire mentioned this issue Mar 18, 2023
Closed
9 tasks
@dignifiedquire
Copy link
Member

I created https://github.com/dignifiedquire/buffer-redux to fix the buf_redux issue.

dignifiedquire added a commit that referenced this issue Mar 18, 2023
@dignifiedquire
refactor: switch from buf_redux to buffer-redux
9eb0f72 
Closes #213
@dignifiedquire dignifiedquire mentioned this issue Mar 18, 2023
Merged
dignifiedquire added a commit that referenced this issue Mar 19, 2023
@dignifiedquire
refactor: switch from buf_redux to buffer-redux
8e42501 
Closes #213
@dignifiedquire dignifiedquire added the dependencies Pull requests that update a dependency file label Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: switch from buf_redux to buffer-redux rpgp/rpgp
3 participants
@dignifiedquire @Skgland @link2xt