Update nom #214
Merged
Update nom #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Very cool, looking forward to reviewing this. Please let me know if you need any help. |
|
@dignifiedquire should now be ready for review |
|
Looking good, just a clippy issue & the |
I checked nom 4 and for slices at_eof was always false https://docs.rs/nom/4.0.0/src/nom/traits.rs.html#988-992
|
I will fix rustfmt together with the fixme once I have an anser regarding that |
|
All manual tests also pass, including no regression in benchmarks. |
dignifiedquire
approved these changes
Mar 17, 2023
|
|
Thanks again! |
Merged
dignifiedquire
pushed a commit
that referenced
this pull request
Mar 18, 2023
* return a couple lost comments to where they belong they apparently got lost on their way from nom 4 to nom 7 * repace `map(parser, |_| const)` with `value(const, parser)` * replace some open coding with combinators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade from nom 4 to nom 7.
Done from scratch rather than using #140 as the rebase was ugly.
TODO