Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFE: Add an labelCompare() equivalent to Lua interface #897

Closed
pmatilai opened this issue Oct 15, 2019 · 0 comments
Closed

RFE: Add an labelCompare() equivalent to Lua interface #897

pmatilai opened this issue Oct 15, 2019 · 0 comments
Labels
lua Lua bindings/interface RFE

Comments

@pmatilai
Copy link
Member

pmatilai commented Oct 15, 2019 •
edited
Loading

Our Lua bindings currently export the low-level rpm.vercmp() function, but this was always the wrong thing to export, it should've been a Python labelCompare() equivalent instead. #561 is probably related too.
@pmatilai pmatilai added RFE lua Lua bindings/interface labels Oct 15, 2019
@pmatilai pmatilai mentioned this issue Feb 27, 2020
Closed
@pmatilai pmatilai mentioned this issue May 14, 2020
Closed
pmatilai added a commit to pmatilai/rpm that referenced this issue May 15, 2020
@pmatilai
Fix Lua rpm.vercmp() to compare actual EVRs instead of segments (rpm-…
4d9c878 
…software-management#897)

The low-level rpmvercmp() was always the wrong thing to export to Lua,
but its what people have used because it's there and its used for
comparing full versions. So rather than add a separate API for the higher
level comparison, lets just change rpm.vercmp() do the right thing instead.

Fixes: rpm-software-management#897
@pmatilai pmatilai mentioned this issue May 15, 2020
Merged
pmatilai added a commit to pmatilai/rpm that referenced this issue May 19, 2020
@pmatilai
Fix Lua rpm.vercmp() to compare actual EVRs instead of segments (rpm-…
9bf0751 
…software-management#897)

The low-level rpmvercmp() was always the wrong thing to export to Lua,
but its what people have used because it's there and its used for
comparing full versions. So rather than add a separate API for the higher
level comparison, lets just change rpm.vercmp() do the right thing instead.

Fixes: rpm-software-management#897
pmatilai added a commit to pmatilai/rpm that referenced this issue May 27, 2020
@pmatilai
Fix Lua rpm.vercmp() to compare actual EVRs instead of segments (rpm-…
e40e2a2 
…software-management#897)

The low-level rpmvercmp() was always the wrong thing to export to Lua,
but its what people have used because it's there and its used for
comparing full versions. So rather than add a separate API for the higher
level comparison, lets just change rpm.vercmp() do the right thing instead.

Fixes: rpm-software-management#897
pmatilai added a commit to pmatilai/rpm that referenced this issue May 27, 2020
@pmatilai
Fix Lua rpm.vercmp() to compare actual EVRs instead of segments (rpm-…
cc9b48f 
…software-management#897)

The low-level rpmvercmp() was always the wrong thing to export to Lua,
but its what people have used because it's there and its used for
comparing full versions. So rather than add a separate API for the higher
level comparison, lets just change rpm.vercmp() do the right thing instead.

Fixes: rpm-software-management#897
@ffesti ffesti closed this as completed in a1d2722 May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lua Lua bindings/interface RFE
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pmatilai