Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error messages for url helper calls #3041

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add error messages for url helper calls #3041

wants to merge 2 commits into from

Commits on Apr 16, 2024

  1. Add error messages for url helper calls 

    Rpm allows URLs as cli parameters. The files are then automatically
downloaded with %_urlhelper which defaults to curl(1). For far failures
have been ignored right away and error messages are generated later when
the file was not found on disk.

Issue a meaningful error message at least when the help program is
missing. This allows not to ship curl with rpm while still giving the
user a chance to find out what is going on.

Related: rhbz#2216754
    @ffesti
    ffesti committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    c7d89aa View commit details
    Browse the repository at this point in the history

  2. Add error messages for url helper calls 

    Give error message if the urlhelper failed (exited with a non zero return
code). This is not quite ideal as the error message from the helper
(typically curl) itself is still not shown but give the user at leat a
hint what is going on.
    @ffesti
    ffesti committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    ffcd207 View commit details
    Browse the repository at this point in the history