Fix test-suite under Fedora 40 modern C rules #3094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple tests are failing on Fedora 40 due to their distro-wide C modernization effort, which cause our ancient "hello world" package to fail due to implicit printf() function usage. There are two separate issues here: - hello-autopatch.spec had off-by-one in its patch application, causing the modernization patch to not apply (see rpm-software-management#3093 for the reason) - others were using the original hello-1.0-1.src.rpm from 2007 with some very outdated practises, code and md5 hashes Update the src.rpm, removing silly fubar while we're at it. Regenerated now on x86_64 so adjust the test-expectation, and update the python archive test to calculate sha256 instead. And, fix the autopatch test numbers.
|
I wonder what happened to the "modernization" patch, though 😄 Since the |
|
IOW, it seems like a noop patch now (haven't tested manually). |
|
The modernization patch never was included in the src.rpm, it's only in separate specs based off that hello.spec. And, we still have the original hello-1.0.tar.gz to which the modernize patch applies (and is applied) in various other tests. |
|
Oh, right, my bad... The SRPM is of course not used in the autopatch test specifically (the tarball is separate indeed). And it's fixed in the SRPM for a reason (to avoid the compiler warning, now error). |
dmnks
added a commit
to dmnks/rpm
that referenced
this pull request
Jun 7, 2024
Require the Dockerfile to also match the host OS release, not just name, in order for mktree to enable "native" mode. In other words, stop overriding the FROM directive with the host OS version and assuming that the rest of the Dockerfile is compatible or tested against it. I was bitten by this recently when I upgraded my workstation to F40 and the tests, only ever tested against F39 at that point, started failing for me (and only me), see rpm-software-management#3094 and rpm-software-management#2799 for details if you're interested. Keep the --from override in mktree, though, as that will allow us to express additional compatible OS releases via Dockerfile symlinks instead of duplicating them (see the next commit).
dmnks
added a commit
to dmnks/rpm
that referenced
this pull request
Jun 7, 2024
Require the Dockerfile also match the host OS release, not just OS name, in order for mktree to enable "native" mode. In other words, stop overriding the FROM directive with the host OS version and assuming that the rest of the Dockerfile is compatible or tested against it. I was bitten by this recently when I upgraded my workstation to F40 and the tests, only ever tested against F39 at that point, started failing for me (and only me), see rpm-software-management#3094 and rpm-software-management#2799 for details if you're interested. Keep the --from override in mktree, though, as that will allow us to express additional compatible OS releases via Dockerfile symlinks instead of duplicating them (see the next commit).
dmnks
added a commit
to dmnks/rpm
that referenced
this pull request
Jun 7, 2024
When looking for a Dockerfile compatible with the host OS (for mktree to work in "native" mode), require that the OS release matches as well. In other words, stop overriding the FROM directive with the host OS version and assuming that the rest of the Dockerfile is compatible or tested against the same. I was bitten by this recently when I upgraded my workstation to F40 and the tests, only ever tested against F39 at that point, started failing for me (and only me), see rpm-software-management#3094 and rpm-software-management#2799 for details. Keep the --from override in mktree, though, as that will allow us to express additional compatible OS releases via Dockerfile symlinks instead of duplicating those files (see the next commit).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple tests are failing on Fedora 40 due to their distro-wide C modernization effort, which cause our ancient "hello world" package to fail due to implicit printf() function usage.
There are two separate issues here:
Update the src.rpm, removing silly fubar while we're at it. Regenerated now on x86_64 so adjust the test-expectation, and update the python archive test to calculate sha256 instead. And, fix the autopatch test numbers.