Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep npm run typings happy #222

Merged
merged 1 commit into from
May 27, 2020

Conversation

eoghanmurray
Copy link
Contributor

Forgot to convert to string.

Incidentally, should npm run typings be part of the test suite?

There are a few unrelated errors when the typings command is run.

@Yuyz0112
Copy link
Member

Yep, now only the release process will run npm run typings

@Yuyz0112 Yuyz0112 merged commit 7d06283 into rrweb-io:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants