Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow fullsnapshot capture to be added along with constructor #416

Merged

Conversation

eoghanmurray
Copy link
Contributor

Allow .on to be chained directly after the constructor so that event handling for the first full snapshot can be added straight after constructor, and that handler will receive the first automatic fullsnapshot build (#216)

Could do with some documentation so you can see:

	var rrweb_replayer = new rrwebReplay.Replayer(
		recording
	).on('fullsnapshot-rebuilded', function(fullSnapshot) {
		// do something with first build
	});

…t handling for the first full snapshot can be added straight after constructor. See rrweb-io#216
@Yuyz0112
Copy link
Member

LGTM

Thanks

@Yuyz0112 Yuyz0112 merged commit 5c9919e into rrweb-io:master Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants