Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to mask inputs #80

Merged
merged 2 commits into from
Jun 15, 2019
Merged

Option to mask inputs #80

merged 2 commits into from
Jun 15, 2019

Conversation

s-jakob
Copy link
Contributor

@s-jakob s-jakob commented Jun 12, 2019

Added option 'maskAllInputs' to replace all user inputs with an Asterisk. This is important here in the EU to avoid recording of sensitiv user data.
ignoreClass is not always the best option, because sometimes you cant add the class everywhere. In addition the mask is nicer to watch, because you see that the user ist typing some stuff.

Added option 'maskAllInputs' to replace all user inputs with an Asterisk.
@Yuyz0112
Copy link
Member

@s-jakob Thanks for the PR and the code looks good to me!

BTW, I think this option should also work for full snapshot which was recorded by the rrweb-snapshot lib. I'm going to apply this into it later this weekend and will release a new version after that.

@Yuyz0112 Yuyz0112 merged commit 189df87 into rrweb-io:master Jun 15, 2019
@s-jakob
Copy link
Contributor Author

s-jakob commented Jun 18, 2019

Very nice. I really like this library. I am working on another feature to add custom events (maybe "tags" is the better name to separate it from the recording events) to the recording to mark special events like checkout or add to card. Did you have something like this planed?

@Yuyz0112
Copy link
Member

@s-jakob Yean I know it is an important feature but not really started to work on that.

And I think a separate issue for some API and implementation discussion will help before you start to do that.

@s-jakob
Copy link
Contributor Author

s-jakob commented Jun 18, 2019

@Yuyz0112 i just added an issue #81

@eoghanmurray
Copy link
Contributor

I wonder should we not mask the following:
<input type="range">
This is just a single value so could hardly constitute sensitive user data?

Also date types are pretty innocuous to allow?

<input type="date">
<input type="datetime-local">
<input type="time">
<input type="week">
<input type="month">

https://www.w3schools.com/html/html_form_input_types.asp

Yuyz0112 added a commit that referenced this pull request Jul 18, 2020
Yuyz0112 added a commit that referenced this pull request Jul 18, 2020
* part of #80, support mask input options

* close #188 enhance sampling options
Use a more general sampling strategy interface to describe the
configuration of sampling events collection.

Implemented mousmove, mouse interaction, scroll and input sampling
strategy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants