Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 'pointer-events: none' for Replayer iframe #96

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

dphuang2
Copy link
Contributor

'pointer-events: none' prevents the user from interacting with the DOM
inside of the iframe. This prevents accidental tampering by a user when
watching replays such as link clicks or DOM manipulation.

pointer-events supported by 97.15% usage: https://caniuse.com/#feat=pointer-events

'pointer-events: none' prevents the user from interacting with the DOM
inside of the iframe. This prevents accidental tampering by a user when
watching replays such as link clicks or DOM manipulation.

pointer-events supported by 97.15% usage: https://caniuse.com/#feat=pointer-events
@Yuyz0112
Copy link
Member

Thanks!

@Yuyz0112 Yuyz0112 merged commit b0ee3f8 into rrweb-io:master Jul 19, 2019
@remisharrock
Copy link

all right, now I found why I can't copy/paste some text in the replayer :) maybe I need to implement a toggle to enable copy/pasting during playback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants