Use node resolution for imports from npm packages #350
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run this script from the deno website in Rustyscript
(assuming you have installed
node-emoji
as a depency in yournode_modules
) you will get an error sayingThis is because
node-emoji
imports@sindresorhus/is"
which has nonpm:
prefix and will not be treated as an npm package by Rustyscript.To fix this, I implemented a check if a dependency is imported from within
node_modules
and then treat it as an npm package, wheather or not it has annpm:
prefix or not.The specific implementation is taken from deno itself: deno/resolvers/deno/lib.rs Lines 242-255, they too check if an import got initiated from within the
node_modules
and issue an npm-package-import.