-
Notifications
You must be signed in to change notification settings - Fork 35
Rewrite Appveyor pipeline, change output directory #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ld-cleanup # Conflicts: # appveyor.yml
@@ -1,7 +1,73 @@ | |||
# ensure CRLF endings on all checkouts | |||
############################################################################### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've regenerated the .git* files using a new VS template (proposed on a new project creation).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comments seems redundant and uninformative.
I find this one is more useful: https://gitattributes.io/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the comments are better than nothing:) The file is generated automatically by VS. If we don't edit it, it will be easier to update - just paste a new variant.
The output of gittattattributes.io is quite specific and looks less organized to me. Also, the output contains diff=astextplain
which is msysgit only feature. (https://gitattributes.io/api/visualstudiocode%2Ccommon%2Ccsharp)
I would keep the current version for now and replace it if there will be any good looking suggestion.
<!-- Redirects everything to '.artifacts\', | ||
same as <UseArtifactsOutput>true</UseArtifactsOutput> in .Net 8 --> | ||
<BaseIntermediateOutputPath Condition="'$(BaseIntermediateOutputPath)' == ''">$(MSBuildThisFileDirectory)\.artifacts\obj\$(MSBuildProjectName)\</BaseIntermediateOutputPath> | ||
<BaseOutputPath Condition="'$(BaseOutputPath)' == ''">$(MSBuildThisFileDirectory).artifacts\$(MSBuildProjectName)\</BaseOutputPath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes output dir to /.artifacts
* https://github.com/microsoft/vstest/issues/880 - dotnet test merges test result for multitargeting test | ||
* https://github.com/nunit/nunit/pull/2724 - PR for appveyor format support (abandoned) | ||
* | ||
#> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script that runs tests over precompiled test assemblies and uploads per-framework results
configuration: Release | ||
image: Visual Studio 2022 | ||
image: Visual Studio 2022 | ||
configuration: Release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appveyor pipeline cleanup
<OutputType>Library</OutputType> | ||
<TargetFrameworks>net6.0;net5.0;net48;net472;net471;net47;net461;net45;net40;net35;netcoreapp3.1</TargetFrameworks> | ||
<TargetFrameworks Condition=" '$(NetCoreTests)' == 'true' ">net6.0;net5.0;netcoreapp3.1</TargetFrameworks> | ||
<TargetFrameworks Condition=" '$(NetFrameworkTests)' == 'true' ">net48;net472;net471;net47;net461;net45;net40;net35</TargetFrameworks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conditional properties are used in pipeline to run tests over specific set of target frameworks
@@ -1,7 +1,73 @@ | |||
# ensure CRLF endings on all checkouts | |||
############################################################################### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the comments are better than nothing:) The file is generated automatically by VS. If we don't edit it, it will be easier to update - just paste a new variant.
The output of gittattattributes.io is quite specific and looks less organized to me. Also, the output contains diff=astextplain
which is msysgit only feature. (https://gitattributes.io/api/visualstudiocode%2Ccommon%2Ccsharp)
I would keep the current version for now and replace it if there will be any good looking suggestion.
No description provided.