Skip to content

Conversation

ig-sinicyn
Copy link
Contributor

No description provided.

@@ -1,7 +1,73 @@
# ensure CRLF endings on all checkouts
###############################################################################
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've regenerated the .git* files using a new VS template (proposed on a new project creation).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments seems redundant and uninformative.
I find this one is more useful: https://gitattributes.io/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the comments are better than nothing:) The file is generated automatically by VS. If we don't edit it, it will be easier to update - just paste a new variant.

The output of gittattattributes.io is quite specific and looks less organized to me. Also, the output contains diff=astextplain which is msysgit only feature. (https://gitattributes.io/api/visualstudiocode%2Ccommon%2Ccsharp)

I would keep the current version for now and replace it if there will be any good looking suggestion.

<!-- Redirects everything to '.artifacts\',
same as <UseArtifactsOutput>true</UseArtifactsOutput> in .Net 8 -->
<BaseIntermediateOutputPath Condition="'$(BaseIntermediateOutputPath)' == ''">$(MSBuildThisFileDirectory)\.artifacts\obj\$(MSBuildProjectName)\</BaseIntermediateOutputPath>
<BaseOutputPath Condition="'$(BaseOutputPath)' == ''">$(MSBuildThisFileDirectory).artifacts\$(MSBuildProjectName)\</BaseOutputPath>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes output dir to /.artifacts

* https://github.com/microsoft/vstest/issues/880 - dotnet test merges test result for multitargeting test
* https://github.com/nunit/nunit/pull/2724 - PR for appveyor format support (abandoned)
*
#>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script that runs tests over precompiled test assemblies and uploads per-framework results

configuration: Release
image: Visual Studio 2022
image: Visual Studio 2022
configuration: Release
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appveyor pipeline cleanup

<OutputType>Library</OutputType>
<TargetFrameworks>net6.0;net5.0;net48;net472;net471;net47;net461;net45;net40;net35;netcoreapp3.1</TargetFrameworks>
<TargetFrameworks Condition=" '$(NetCoreTests)' == 'true' ">net6.0;net5.0;netcoreapp3.1</TargetFrameworks>
<TargetFrameworks Condition=" '$(NetFrameworkTests)' == 'true' ">net48;net472;net471;net47;net461;net45;net40;net35</TargetFrameworks>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional properties are used in pipeline to run tests over specific set of target frameworks

@@ -1,7 +1,73 @@
# ensure CRLF endings on all checkouts
###############################################################################
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the comments are better than nothing:) The file is generated automatically by VS. If we don't edit it, it will be easier to update - just paste a new variant.

The output of gittattattributes.io is quite specific and looks less organized to me. Also, the output contains diff=astextplain which is msysgit only feature. (https://gitattributes.io/api/visualstudiocode%2Ccommon%2Ccsharp)

I would keep the current version for now and replace it if there will be any good looking suggestion.

@ig-sinicyn ig-sinicyn merged commit 2f3d430 into master Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants