Add database_exists? method to connection adapters #1906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary Follow up rails/rails#36471. Oracle enhanced adapter has no implementation because Oracle Database cannot detect `NoDatabaseError`. Please refer to the following discussion for details. rsim#1900 ### Other Information The following is an implementation example I gave up. ```diff diff --git a/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb b/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb index af99718..77a5b90 100644 --- a/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb +++ b/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb @@ -249,6 +249,12 @@ module ActiveRecord ADAPTER_NAME end + def self.database_exists?(config) + !!ActiveRecord::Base.oracle_enhanced_connection(config) + rescue ActiveRecord::NoDatabaseError + false + end + ``` This is an implementation example when `NoDatabaseError` can be supported in the future.
|
As discussed at Asakusa.rb, I wanted Oracle enhanced adapter have own |
|
Thank you for the supplementary explanation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up rails/rails#36471.
Oracle enhanced adapter has no implementation because Oracle Database cannot detect
NoDatabaseError.Please refer to the following discussion for details.
#1900
Other Information
The following is an implementation example I gave up.
This is an implementation example when
NoDatabaseErrorcan be supported in the future.