Enable RSpec/RepeatedExample cop
#2278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahonda
changed the title
RSpec/RepeatedExampleRSpec/RepeatedExample cop
This cop actually finds the actual repeated examples below. So let's
remove them.
```ruby
$ bundle exec rubocop
Inspecting 72 files
....................................................C...................
Offenses:
spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:219:5: C: RSpec/RepeatedExample: Don't repeat examples within an example group.
it "should dump table comments" do ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:226:5: C: RSpec/RepeatedExample: Don't repeat examples within an example group.
it "should dump column comments" do ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:233:5: C: RSpec/RepeatedExample: Don't repeat examples within an example group.
it "should dump table comments" do ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:240:5: C: RSpec/RepeatedExample: Don't repeat examples within an example group.
it "should dump column comments" do ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
72 files inspected, 4 offenses detected
$
```
yahonda
force-pushed
the
remove_redundant_cop
branch
from
f24e8b7 to
f4af832
Compare
|
Nice improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cop actually finds the actual repeated examples below. So let's
remove them.