Skip to content

Conversation

brandongregoryscott
Copy link
Contributor

  • Move axios, lodash, etc. prod dependencies to dev + peer dependencies and remove unused React testing-library deps
  • Update README to reflect updated peer dependency usage and merge w/ existing documentation for global dist

Note: The only production dependency I left was query-string, since it seems to have been intentionally bundled in with the global distribution of the package.

Fixes #95 Reevaluate production vs. peer/dev dependencies

  • Related GitHub issue(s) linked in PR description
  • Destination branch merged, built and tested with your changes
  • Code formatted and follows best practices and patterns
  • Code builds cleanly (no additional warnings or errors)
  • Manually tested
  • Automated tests are passing
  • No decreases in automated test coverage
  • Documentation updated (readme, docs, comments, etc.)
  • [-] Localization: No hard-coded error messages in code files (minimally in string constants)

@brandongregoryscott brandongregoryscott added the dependencies Pull requests that update a dependency file label Feb 15, 2021
@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #98 (8fa8aa0) into main (c1e2ff5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #98   +/-   ##
=======================================
  Coverage   95.23%   95.23%           
=======================================
  Files          26       26           
  Lines         546      546           
  Branches      106      106           
=======================================
  Hits          520      520           
  Misses         25       25           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1e2ff5...a8d0db2. Read the comment docs.

Copy link
Contributor

@wintondeshong wintondeshong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together @brandongregoryscott

@brandongregoryscott
Copy link
Contributor Author

Thanks for putting this together @brandongregoryscott

For sure! I figure this will at least help us resolve some of the weirdness we were seeing while trying to test out changes + manage dependency versions. I still plan on digging into codependency & possibly tackling some of those issues they have out, but we can reevaluate again down the road 👍

@brandongregoryscott brandongregoryscott merged commit b0719bb into rsm-hcd:main Mar 26, 2021
@brandongregoryscott brandongregoryscott deleted the support/peer-vs-production-deps-2 branch March 26, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reevaluate production vs. peer/dev dependencies

2 participants