Skip to content

Conversation

brandongregoryscott
Copy link
Contributor

Fixes issue #10

Added in some missing explicit types and a JSDoc comment, too.

@brandongregoryscott brandongregoryscott requested review from a team and wintondeshong June 24, 2020 23:03
@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #11   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          156       158    +2     
  Branches        18        18           
=========================================
+ Hits           156       158    +2     
Impacted Files Coverage Δ
src/tests/factories/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82fd493...65e5e05. Read the comment docs.

Copy link
Contributor

@wintondeshong wintondeshong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brandongregoryscott ! perfect timing as I need these right now :) - i'll go ahead and merge it and bundle it in the release I'll likely be creating today. Add a hook right now.

@wintondeshong wintondeshong added the bug Something isn't working label Jun 26, 2020
@wintondeshong wintondeshong merged commit 6b5f87d into rsm-hcd:master Jun 26, 2020
@brandongregoryscott brandongregoryscott deleted the support/switch-to-named-exports branch July 12, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants