Skip to content

Conversation

jhugs
Copy link
Contributor

@jhugs jhugs commented Jul 28, 2020

Fixes #27

Tested with @brandongregoryscott and seemed to fix issue of relative imports breaking in packaged js.

  • Related GitHub issue(s) linked in PR description
  • Destination branch merged, built and tested with your changes
  • Code formatted and follows best practices and patterns
  • Code builds cleanly (no additional warnings or errors)
  • Manually tested
  • Automated tests are passing
  • No decreases in automated test coverage
  • [-] Documentation updated (readme, docs, comments, etc.)
  • [-] Localization: No hard-coded error messages in code files (minimally in string constants)

@jhugs jhugs requested review from a team, brandongregoryscott and wintondeshong July 28, 2020 20:58
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@4844482). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             master       #28   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?         9           
  Lines             ?       166           
  Branches          ?        18           
==========================================
  Hits              ?       166           
  Misses            ?         0           
  Partials          ?         0           
Impacted Files Coverage Δ
src/services/service-factory.ts 100.00% <0.00%> (ø)
src/tests/factories/route-map-factory.ts 100.00% <0.00%> (ø)
src/hooks/use-cancellable-promise.ts 100.00% <0.00%> (ø)
src/tests/factories/index.ts 100.00% <0.00%> (ø)
src/tests/factories/route-definition-factory.ts 100.00% <0.00%> (ø)
src/tests/factories/factory-type.ts 100.00% <0.00%> (ø)
src/hooks/use-localization.ts 100.00% <0.00%> (ø)
src/services/service-hook-factory.ts 100.00% <0.00%> (ø)
src/utilities/route-utils.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4844482...7273946. Read the comment docs.

Copy link
Contributor

@wintondeshong wintondeshong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will give this a whirl after we merge and publish

@wintondeshong wintondeshong merged commit 797b8ae into rsm-hcd:master Jul 29, 2020
@wintondeshong
Copy link
Contributor

Released with version 0.1.1

@brandongregoryscott
Copy link
Contributor

@all-contributors add @jhugs for code

@allcontributors
Copy link
Contributor

@brandongregoryscott

I've put up a pull request to add @jhugs! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove baseUrl from tsconfig.json

3 participants