Fix NestedRoutes 'redirectToIfNotFound' bug

[brandongregoryscott]

Fixes #26

Wrap NestedRoutes render in <Switch> and expand route as props to individual NestedRoute to fix fall-through to <Redirect>, add test for this case

• Related GitHub issue(s) linked in PR description
• Destination branch merged, built and tested with your changes
• Code formatted and follows best practices and patterns
• Code builds cleanly (no additional warnings or errors)
• Manually tested
  • See sandbox app with a static build of this fix: https://damp-eyrie-79964.herokuapp.com
  • See sandbox app with the current version of this package for previous behavior: https://protected-lake-80234.herokuapp.com
• Automated tests are passing
• No decreases in automated test coverage
• [-] Documentation updated (readme, docs, comments, etc.)
• [-] Localization: No hard-coded error messages in code files (minimally in string constants)

[codecov]

Codecov Report

Merging #29 into master will decrease coverage by 6.34%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##            master      #29      +/-   ##
===========================================
- Coverage   100.00%   93.65%   -6.35%     
===========================================
  Files            9       12       +3     
  Lines          166      205      +39     
  Branches        18       23       +5     
===========================================
+ Hits           166      192      +26     
- Misses           0       12      +12     
- Partials         0        1       +1     

Impacted Files	Coverage Δ
src/components/routing/nested-routes.tsx	91.66% <100.00%> (ø)
src/tests/factories/route-definition-factory.ts	100.00% <100.00%> (ø)
src/components/routing/authenticated-route.tsx	26.66% <0.00%> (ø)
src/components/routing/nested-route.tsx	91.66% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 210b753...63d9d11. Read the comment docs.

[brandongregoryscott]

🤦 Looks like codecov is seeing a decrease in coverage, probably because this is the first set of tests that are hitting any of the routing components. I'll add some issues to backfill tests for these.

[wintondeshong]

@brandongregoryscott thank you for troubleshooting this issue! I'm going to accept, merge and build a release. Going to update the boilerplate to use this. Nice work!

As for test coverage, yeah, I see what you mean. No worries! This is an increase in coverage in my book 👍

[wintondeshong]

Thought: Could be wrong, but think you could spare the extra setup of 'history' by using MemoryRouter.

[brandongregoryscott]

Ah, yeah, I was seeing that in the docs too. Wasn't sure how I would simulate a navigation change, though it looks like MemoryRouter has an initialEntries prop which may have worked the same way.

[wintondeshong]

@brandongregoryscott Thank you for writing tests for this!