Get createManagedInstance to work with Subscriber<T> where T != Payload #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stance` with a `Subscriber<T>` where `T != Payload`. test/simple/SubscriberNonPayloadTest.cpp will fail without the changes to MemoryMixin.h Other mixins also refer to Payload directly, but I can fix those up in subsequent diffs.
src/mixins/MemoryMixin.h
Outdated
| /// is implementing the (virtual) methods of the | ||
| /// Subscription or the Subscriber interface. | ||
| template <typename Base> | ||
| template <typename Base, typename Payload = Payload> |
There was a problem hiding this comment.
If I understand the intention of your change, shouldn't this be?
typename T = Payload
Reactive Streams isn't tied to Payload https://github.com/ReactiveSocket/reactive-streams-cpp/blob/master/include/ReactiveStreams.h
There was a problem hiding this comment.
Sure typename T = Payload. The issue is on line 71 below where we have
void onNext(Payload payload) {
I want Payload to be generic. typename T = Payload might be more explicit and then I'll change Payload elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With -Werror and -Woverloaded-virtual, we cannot use
createManagedInstancewith aSubscriber<T>whereT != Payload.test/simple/SubscriberNonPayloadTest.cpp will fail without the changes to MemoryMixin.h
Other mixins also refer to Payload directly, but I can fix those up in subsequent diffs.