Using RxNetty for tcp transport #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current TCP transport implementation lacks a few critical features around insights and network flow control. Since RxNetty already has these features, it makes sense to use it.
…cket-java into rxnetty # Conflicts: # reactivesocket-examples/src/main/java/io/reactivesocket/examples/EchoClient.java # reactivesocket-transport-tcp/src/main/java/io/reactivesocket/transport/tcp/client/ClientTcpDuplexConnection.java # reactivesocket-transport-tcp/src/main/java/io/reactivesocket/transport/tcp/client/TcpReactiveSocketConnector.java
…cket-java into rxnetty # Conflicts: # reactivesocket-examples/src/main/java/io/reactivesocket/examples/EchoClient.java # reactivesocket-transport-tcp/src/main/java/io/reactivesocket/transport/tcp/client/ClientTcpDuplexConnection.java # reactivesocket-transport-tcp/src/main/java/io/reactivesocket/transport/tcp/client/TcpReactiveSocketConnector.java
|
|
||
| System.out.println(response); | ||
| RxReactiveStreams.toObservable(client.requestResponse(request)) | ||
| .map(payload -> { |
There was a problem hiding this comment.
This example would be a lot nicer with a utility function
.map(PayloadUtil::dataAsString)
Also 2000 era nit that new String() isn't safe without specifying encoding
There was a problem hiding this comment.
Agreed.
My just another rant about ByteBuffer API, as compared to netty's ByteBuf API which enables this:
.map(bb -> bb.toString(Charset.defaultCharset())))😞
Also updated to rxnetty-0.5.2-rc.3
|
@yschimke @stevegury addressed all comments and updated to latest RxNetty |
| ByteBuffer data = payload.getData(); | ||
| byte[] dst = new byte[data.remaining()]; | ||
| data.get(dst); | ||
| return new String(dst); |
There was a problem hiding this comment.
We'll add a charset in another commit ;-)
There was a problem hiding this comment.
Thanks Steve - I'm looking out for the EBCDIC users of the world
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Current TCP transport implementation lacks a few critical features around insights and network flow control.
Solution
Since RxNetty already has these features, it makes sense to use it.
This is a backward incompatible change as it removes some public classes
EchoClientin examples module contains the usage example.