Wire onSubscribe in *Connector.
#99
Conversation
**Problem** Instead of manually requesting in the `onSubscribe`, it's better to actually pass the `Subscription` to the `Subscriber`. The *Connector code was a little bit confusing because the `Subscriber` like the `Subscription` were names `s`. **Solution** Rename the `Subscriber` -> `subscriber`, and pass the subscription.
|
Ok so this is working today because no where in the code we are actually validating backpressure for this invocation i.e. if we receive an |
|
The main problem here, is that we're requesting 1 DuplexConnection without ensuring that the Publisher chain of the ReactiveSocket is initialized. We were breaking the chain by introducing a For instance, this fixes the problem when you receive an |
|
Yes I understood that. My surprise was "why was it working till now?" :) Which I think is because we do not do this sanity check: "Did I get an Anyways, this change looks good, merging.. |
Problem
Instead of manually requesting in the
onSubscribe, it's betterto actually pass the
Subscriptionto theSubscriber.The *Connector code was a little bit confusing because the
Subscriberlike the
Subscriptionwere namess.Solution
Rename the
Subscriber->subscriber, and pass the subscription.