New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: apollo graphql link and server #225

Merged

viglucci merged 25 commits into 1.0.x-alpha from feature/apollo-graphql-link-server

Apr 29, 2023

Member

viglucci commented May 8, 2022 •

edited

Loading

Adds experimental ApolloLink and ApolloServer implementations to support GraphQL over RSocket with Apollo GraphQL.

Motivation:

Spring recently added support for GraphQL over RSocket, and we were interested to see if we could provide similar support via rsocket-js. This addition will provide a mechanism for consuming RSocket transport using GraphQL servers via JS clients (browser etc.).

Additionally, these additions provide an interesting alternative to existing Apollo GraphQL subscription links, such as graphql-ws. Existing GraphQL subscription users could now benefit from a potentially increased number of available transport protocol options. I believe it would be beneficial for these advancements to be more broadly broadcasted and advocated for in the GraphQL community.

Modifications:

added rsocket-graphql-apollo-link package
added rsocket-graphql-apollo-server package
provided examples for using new packages

Result:

See above.

Related:

Open questions/items:

Are we improperly assuming a route will be used/required on the server?
Are we sending the proper metadata mime type on SETUP and request?
Are errors being handled according to spec?
Test Interop with Spring server/client.

viglucci added the 1.0 label

viglucci commented

View reviewed changes

packages/rsocket-graphql-apollo-server/src/ApolloServer.ts Outdated

Comment on lines 114 to 124

+                      runHttpQuery([], {
+                        method: "POST",
+                        options: () => {
+                          return this.createGraphQLServerOptions(payload);
+                        },
+                        query,
+                        request: new Request("/graphql", {
+                          headers: new Headers(),
+                          method: "POST",
+                        }),
+                      })

Member Author

viglucci May 8, 2022

From what I can tell, runHttpQuery seems to be the best entry point into Apollo's logic for handling a query. This feels strange for our use case, seeing as we are not HTTP, so I'll likely reach out to Apollo and see if there is a better way to process a query that is completely divorced from HTTP concepts.

OlegDokuka reviewed

View reviewed changes

packages/rsocket-tcp-server/src/TcpDuplexConnection.ts Outdated Show resolved Hide resolved

viglucci force-pushed the feature/apollo-graphql-link-server branch from c436421 to 4748c68 Compare

May 8, 2022 20:56

Member Author

viglucci commented May 25, 2022 •

edited

Loading

Moving this PR out of draft is pending investigating Apollo's executeOperation, as suggested here.

viglucci marked this pull request as ready for review

September 4, 2022 22:34

viglucci changed the title ~~(draft) feat: apollo graphl link and server~~ feat: apollo graphl link and server

viglucci force-pushed the feature/apollo-graphql-link-server branch from 47455e4 to ac6ac87 Compare

September 4, 2022 23:01

Member Author

viglucci commented Sep 4, 2022

I will fix DCO on merge.

viglucci requested a review from OlegDokuka

September 4, 2022 23:18

viglucci changed the title ~~feat: apollo graphl link and server~~ feat: apollo graphql link and server

viglucci force-pushed the feature/apollo-graphql-link-server branch 2 times, most recently from bb1efc5 to 039d96e Compare

November 2, 2022 14:47

viglucci and others added 17 commits

April 26, 2023 20:15


          feat: apollo graphl link and server

380237c

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>


          fix/custom metadata header alloc (#231)

9a81261

* fix: clear buffer when allocating for custom metadata header

* test: add composite metadata tests

- encodeAndAddCustomMetadata
- encodeCustomMetadataHeader

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>


          chore(release): release

ea8a790

 - rsocket-adapter-rxjs@1.0.0-alpha.2
 - rsocket-composite-metadata@1.0.0-alpha.2
 - rsocket-examples@1.0.0-alpha.2
 - rsocket-messaging@1.0.0-alpha.2

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>


          test: add encodeWellKnownMetadataHeader test

b6d2392

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>


          test: add encodeAndAddWellKnownMetadata tests

07e3dc3

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>


          test: add encodeCompositeMetadata tests

f32c338

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>


          Optional metadata for rxjs requesters (#241)

e05b933

* feat: support optional metadata in rxjs adapter requesters

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>

* chore(release): release

 - rsocket-adapter-rxjs@1.0.0-alpha-rxjs-adapter-optional-metadata.0
 - rsocket-composite-metadata@1.0.0-alpha-rxjs-adapter-optional-metadata.0
 - rsocket-core@1.0.0-alpha-rxjs-adapter-optional-metadata.0
 - rsocket-examples@1.0.0-alpha-rxjs-adapter-optional-metadata.0
 - rsocket-messaging@1.0.0-alpha-rxjs-adapter-optional-metadata.0
 - rsocket-tcp-client@1.0.0-alpha-rxjs-adapter-optional-metadata.0
 - rsocket-tcp-server@1.0.0-alpha-rxjs-adapter-optional-metadata.0
 - rsocket-websocket-client@1.0.0-alpha-rxjs-adapter-optional-metadata.0
 - rsocket-websocket-server@1.0.0-alpha-rxjs-adapter-optional-metadata.0

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>


          chore(release): release

9b4bd5e

 - rsocket-adapter-rxjs@1.0.0-alpha.3
 - rsocket-composite-metadata@1.0.0-alpha.3
 - rsocket-core@1.0.0-alpha.3
 - rsocket-examples@1.0.0-alpha.3
 - rsocket-messaging@1.0.0-alpha.3
 - rsocket-tcp-client@1.0.0-alpha.3
 - rsocket-tcp-server@1.0.0-alpha.3
 - rsocket-websocket-client@1.0.0-alpha.3
 - rsocket-websocket-server@1.0.0-alpha.3

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>


          chore: expand rxjs example to leverage fire and forget

81ff1fc

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>


          refactor: rename rxjs messaging composite metadata routing example

04d3c40

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>


          chore: add rxjs example without rsocket-messaging

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>


          fixes request channel to drop second element (#244)

995a664

unexpectedly, in the rxjs `partition` operator the index is a local variable per subscription, thus the second subscription starts indexing from 0 once again even though the element is a second one (index should be 1 in that case). Therefore, to overcome this problem the PR introduces a local variable to track the first element.

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>


          chore(release): release

1326c62

 - rsocket-adapter-rxjs@1.0.0-alpha.4
 - rsocket-examples@1.0.0-alpha.4

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>


          docs: update release docs with example lerna command

d7bb535

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>


          feat: add RSocketApolloGraphlQLPlugin (apollographql/apollo-server#6264)

2bba130

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>


          fix: remove lerna-debug.log

871946d

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>


          chore(release): release

d28ffd4

 - rsocket-adapter-rxjs@1.0.0-alpha.2
 - rsocket-composite-metadata@1.0.0-alpha.2
 - rsocket-examples@1.0.0-alpha.2
 - rsocket-messaging@1.0.0-alpha.2

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>

viglucci added 5 commits

April 26, 2023 20:15


          Optional metadata for rxjs requesters (#241)

bd1a27a

* feat: support optional metadata in rxjs adapter requesters

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>

* chore(release): release

 - rsocket-adapter-rxjs@1.0.0-alpha-rxjs-adapter-optional-metadata.0
 - rsocket-composite-metadata@1.0.0-alpha-rxjs-adapter-optional-metadata.0
 - rsocket-core@1.0.0-alpha-rxjs-adapter-optional-metadata.0
 - rsocket-examples@1.0.0-alpha-rxjs-adapter-optional-metadata.0
 - rsocket-messaging@1.0.0-alpha-rxjs-adapter-optional-metadata.0
 - rsocket-tcp-client@1.0.0-alpha-rxjs-adapter-optional-metadata.0
 - rsocket-tcp-server@1.0.0-alpha-rxjs-adapter-optional-metadata.0
 - rsocket-websocket-client@1.0.0-alpha-rxjs-adapter-optional-metadata.0
 - rsocket-websocket-server@1.0.0-alpha-rxjs-adapter-optional-metadata.0

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>


          refactor: rename QueryLink to RSocketQueryLink

7feed29

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>


          refactor: rename SubscriptionLink to RSocketSubscriptionLink

c377d6a

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>


          chore: add simple webpack example (#246)

a0fb7ba

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>
Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>


          fix: merge conflict missing comma in package.json

03439d8

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>

viglucci force-pushed the feature/apollo-graphql-link-server branch from d935d63 to 03439d8 Compare

April 27, 2023 01:32

Member Author

viglucci commented Apr 27, 2023

Rebased to fix resolve DCO check issue.

viglucci added 3 commits

April 26, 2023 20:42


          Merge branch '1.0.x-alpha' into feature/apollo-graphql-link-server

b7b9149


          chore: expand gql client example to leverage subscription

5ae8115

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>


          chore: run linter

1982a3d

Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>

viglucci merged commit e7f4f5f into 1.0.x-alpha

viglucci deleted the feature/apollo-graphql-link-server branch

April 29, 2023 03:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.0