Reworked fragmentation, Client & Server keep-alive improvements, RSocketFactory simplification #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce RSocket server contract interceptor; move Setup frame validation from RSocketFactory Move fragmentation from RSocketFactory to Connection interceptor RSocketFactory api simplification renames: RSocketClient -> RSocketRequester, RSocketServer -> RSocketResponder, PluginRegistry -> InterceptorRegistry rename RSocketInterceptor responder -> handler Release setup frame after decoding
Reimplemented fragmentation and reassembly logic as previously It did not distinguish between Payload and Request* frames and crashed consistently. Also made sure FrameFragmenter does not leak frame contents if unsubscribed before all fragments of frame are passed to subscriber
mostroverkhov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client and Server keep-alive implemented according to spec
Introduce RSocket server contract interceptor; move Setup frame validation from RSocketFactory
Move fragmentation from RSocketFactory to Connection interceptor
RSocketFactory API simplification
Renames: RSocketClient -> RSocketRequester, RSocketServer -> RSocketResponder, PluginRegistry -> InterceptorRegistry
Leak fix: release setup frame after decoding
Reimplemented fragmentation and reassembly logic as previously
It did not distinguish between Payload and Request* frames and crashed
consistently.