Skip to content

Bump dashmap to latest version #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2022
Merged

Bump dashmap to latest version #57

merged 3 commits into from
Jun 23, 2022

Conversation

adoerr
Copy link
Contributor

@adoerr adoerr commented Jun 22, 2022

Bump dashmap to latest version

Motivation:

There is RUSTSEC-2022-0002 Unsoundness in dashmap references. This advisory is relevant for version 5.0.0 of dashmap

Since we are still using version 4.0.2 we are not affected. However, if a GitHub repository with rsocket as a dependency has automated security advisories enabled, a false positive security issue will be crated. The alarm is a false positive because GitHub does not realize, that version 4.0.2 is not affected.

In order so resolve this GitHub security advisory, I have bumped dashmap to the latest version.

Modifications:

  • bump dashmap to latest version
  • fix some clippy issues

adoerr and others added 3 commits June 22, 2022 12:51
Signed-off-by: adoerr <0xad@gxm.net>
Signed-off-by: adoerr <0xad@gxm.net>
Signed-off-by: adoerr <0xad@gmx.net>
@adoerr
Copy link
Contributor Author

adoerr commented Jun 23, 2022

@jjeffcaii should be a quick one to review

Copy link
Member

@jjeffcaii jjeffcaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjeffcaii jjeffcaii merged commit 822405f into rsocket:master Jun 23, 2022
@adoerr adoerr deleted the ad-bump-dashmap branch June 23, 2022 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants