Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified logic yo use == instead of is to make sure we dont encounter… #160

Conversation

RaviChandraVeeramachaneni
Copy link
Contributor

… warnings

Copy link
Owner

@rsokl rsokl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This will be in the next release of PLYMI :)

@rsokl
Copy link
Owner

rsokl commented Aug 14, 2020

closes #159

@rsokl rsokl merged commit 9a16579 into rsokl:master Aug 14, 2020
@RaviChandraVeeramachaneni
Copy link
Contributor Author

@rsokl
Copy link
Owner

rsokl commented Aug 20, 2020

@RaviChandraVeeramachaneni it would be best for you to post those ideas in the issue thread on this GitHub repo. This way the other PLYMI contributors/developers can participate in the discussions about ideas / new content.

Best regards,
Ryan

@RaviChandraVeeramachaneni
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants