The Html formatter does not keep the failed count correctly #265

Closed
scrummyin opened this Issue Jan 3, 2011 · 3 comments

Projects

None yet

2 participants

@scrummyin

Each time example_failed is called it resets the counter to zero. Counter is then used to generate id's which are always id="failure_0". If @counter were set in the constructed and added to each time example_failed was called this would fix the issue.

@dchelimsky
Member

Care to submit a patch?

@scrummyin

Here you go:
scrummyin@86bd44f

Also, it was affecting the textmate formatter as well. Let me know if you want something more. Or a different format, because I'm not used to committing patches to other people's code on github. So let me know if there is better etiquette.

@dchelimsky
Member

corrected the count in the html formater

@timcharper timcharper pushed a commit to timcharper/rspec-core that referenced this issue Aug 19, 2011
@scrummyin @dchelimsky scrummyin + dchelimsky corrected the count in the html formater
- Closes #265.
ad79868
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment