Adds RSpec.current_example
#1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated the commit message to say 2.99 and 3.0. 2.14 isn't relevant here. My mistake originally. |
|
I think we will want to backport this to 2.99, but not 2.14. |
|
Yeah we'd need to backport this to |
| @@ -490,8 +482,11 @@ def instance_exec_with_rescue(example, context = nil, &hook) | |||
| begin | |||
| instance_exec(example, &hook) | |||
| rescue Exception => e | |||
| raise unless @_current_rspec_example | |||
| @_current_rspec_example.set_exception(e, context) | |||
There was a problem hiding this comment.
I think I preferred the previous format...
There was a problem hiding this comment.
Aw, really? :) Why is that? I found the explicit conditional easier to parse in my mind. That said, I'm willing to be convinced.
There was a problem hiding this comment.
I mentally parse it as "we must error unless we have an example to set the exception on"
* Library authors that want to support RSpec 2 and 3 can use `RSpec.current_example` to find the current example in a hook method. In RSpec versions before 2.99, `self.example` can be used (but `self.example` is deprecated in RSpec >= 2.99 and removed in RSpec 3).
* While RSpec isn't necessarily thread safe right now, it might be in the future.
|
Ready for re-review: |
|
LGTM. Merge when green. |
alindeman
added a commit
that referenced
this pull request
Jul 21, 2013
Adds `RSpec.current_example`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can use
RSpec.current_exampleto find the current example in a hookmethod. In RSpec versions before 2.99,
self.examplecan be used (butself.exampleis deprecated in RSpec >= 2.99 and removed in RSpec 3).