This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Support for tags on CLI #205
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple support for tags, as described in http://github.com/rspec/rspec-core/issues/37.
|
Really nice work. Will definitely be merging this in (still catching up on a long task list after a week on the road). |
|
Thanks David. As I said, it's a simple implementation, but I think filters on CLI should be kept simple indeed. |
|
Wow, this is a really nice feature. I'll definitely be using it a lot! |
|
Added support for filtering with tags on CLI. Simple support for tags, as described in http://github.com/rspec/rspec-core/issues/37.
|
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filters are one of my favorite things on RSpec 2, specially because I don't use Cucumber. But is very cumbersome always have to set
filter_run_includingandfilter_run_excludingon the spec_helper file, so I implemented a simple support for tags on the CLI.It is just a subset of the described by David in http://github.com/rspec/rspec-core/issues/#issue/37 (actually just the section "keys and/or key/value pairs"), but I think it covers most cases. To see exactly what was implemented, refer to the Cucumber feature http://github.com/lailsonbm/rspec-core/blob/b4501b6d5e9d7ddc930d5d4cec05f1cc0d201897/features/command_line/tag.feature.