This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Fix rcov integration on windows (or platoform where PATH_SEPARATOR != : more generally) #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes incorrect behavior on windows platform where PATH_SEPARATOR is set to ';' which tricks rcov to add "spec;lib" to path instead of adding ["spec", "lib"].
|
This would be really useful to incorporate in order to support rcov on windows properly. If you check the rcov source it clearly does not use the PATH_SEPARATOR, always uses ":". Thanks |
|
Already changed in 06b4122 - will be part of 2.7, coming no later than early November. |
|
fantastic - thank you very much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes incorrect behavior on windows platform where PATH_SEPARATOR
is set to ';' which tricks rcov to add "spec;lib" to path instead
of adding ["spec", "lib"].