Move to Github Actions?

[benoittgt]

Hello

I saw few recent OSS projects that move to Github Actions. I did a very basic try with rspec-core and only with MRI at the moment.

https://github.com/benoittgt/rspec-core/commit/70abad7b1d3fbdd21d9270e09a07a1fbc397df7c/checks?check_suite_id=392910092

For the moment I do not see a big improvement. Also I had to do ugly things to make the build green quickly.

The config for rspec-rails will be more complex.

To be honest I think it is maybe too early to move. I do no see a gain in execution time and debugging for the moment.

This issue is not a real one. I just open a discussion. I am also curious if you think we should switch to Github Actions.

Closing because it is only a discussion.

[benoittgt]

I have different behavior when I use bin/rspec instead of https://github.com/benoittgt/rspec-core/blob/c25a2df53db05a107ec7b5dd428e0455757bd4c8/script/functions.sh#L70-L77

It is failing with shell commands, but not with bin/rspec

[benoittgt]

$ ruby -e 'puts Dir["spec/**{,/*/**}/*_spec.rb"]' | wc -l
     152
$ find spec -iname '*_spec.rb' | wc -l
     76

Why we are not using bin/rspec?

[JonRowe]

I'm not sure I understand what you're asking?

[benoittgt]

Sorry Jon. After digging, I found the answer. I was worried we were running multiple time bin/rspec with the same files. It doesn't seems to be the case. So case close. :)

---

I am still playing with Github Actions. I found that running

require "rspec"
require "rspec/core/rake_task"
RSpec::Core::RakeTask.new.run_task(false)

On Github actions produce this warning:

/opt/hostedtoolcache/Ruby/2.6.3/x64/lib/ruby/gems/2.6.0/gems/rspec-core-3.9.1/lib/rspec/core/rake_task.rb:97: warning: Insecure world writable dir /opt/hostedtoolcache/Ruby/2.6.3/x64/bin in PATH, mode 040777
No examples found.


Finished in 0.00021 seconds (files took 0.05324 seconds to load)
0 examples, 0 failures

[benoittgt]

Ok, the warning is produced by RUBY from:

require 'rake'
require 'rake/tasklib'

system("#{Rake::TaskLib::RUBY} -e 'p :foo'")

See: actions/runner-images#267

[benoittgt]

Ok we gonna to move this subject a little bit faster if TravisCI drop OSS. ATM I have issues on basic rspec-core project. Here is the config file. https://github.com/benoittgt/actions_ruby_testing/blob/master/.github/workflows/ruby.yml

And a CI result https://github.com/benoittgt/actions_ruby_testing/runs/1343435673

[JonRowe]

It seems we can migration to travis-ci.com and use the free 10000 credits, but I'm not sure how much that would give us, as travis-ci.org was taking hours and hours during the release process for 3.10 I started investigating over here:

https://github.com/rspec/rspec-core/tree/experimental-github-actions

I got rspec-core passing on 2.5 2.6 and 2.7 but none of the earlier versions, so I started looking at how to deal with older Ruby versions.

[pirj]

Just checked rubocop-rspec's CircleCI plan page:

Plan Free
1 concurrent job with access to Linux and Windows builds on Small and Medium sizes

Credits
You have used 9,516 of 2,500 credits
9,516 used -7,016 available

At least you can go to the red zone ;D

Circle is out from my point of view.

[benoittgt]

For more ruby version I think we should switch to https://github.com/ruby/setup-ruby for example https://github.com/rspec/rspec-core/runs/1343995732

Ruby switch seems good... but I still have the resolve issue of

     rspec-xxxx was resolved to 3.10.0.pre, which depends on
      rspec-yyyy (= 3.10.0.pre)

[JonRowe]

 rspec-xxxx was resolved to 3.10.0.pre, which depends on
      rspec-yyyy (= 3.10.0.pre)

There is no 3.10.0pre, you have stale repos.

[pirj]

You may find this handy if you don't already have this open :D https://docs.github.com/en/free-pro-team@latest/actions/learn-github-actions/migrating-from-circleci-to-github-actions