Combine 'any instance' cukes

[soulcutter]

expect_any_instance_of.feature and any_instance.feature both have the same Feature description, which makes navigating relish app confusing:

To resolve this, I combined those files.

Additionally I would like to pose the question of whether it makes sense to combine message_expectations/allow_any_instance_of.feature with method_stubs/any_instance.feature ?

[coveralls]

Coverage decreased (-0%) when pulling 336b691 on any_instance-combine-features into 55f06e7 on master.

[myronmarston]

Thanks for taking initiative on this, @soulcutter. Long term, I'm thinking I'd rather the cukes use the new syntax consistently everywhere, and then we can have on cuke file that demonstrates usage of the old syntax (but doesn't show every last feature of it).

Do you think it makes sense to move in that direction now?

[soulcutter]

Yeah, now is probably the time to start that conversion. What are we calling the old syntax anyway? monkey-patched? extended Object? old?..

Argh, looks like my merge was not quite right either. 😕

[myronmarston]

What are we calling the old syntax anyway? monkey-patched? extended Object? old?..

We discussed several options in #266. Originally I was going to call the syntaxes :wrapped and :direct but we decided to go with :should and :expect for parity with rspec-expectations.

[myronmarston]

Why not use expect here?

[JonRowe]

👍 especially give you're setting the expectation with the new syntax

[coveralls]

Coverage decreased (-0%) when pulling 3751953 on any_instance-combine-features into 55f06e7 on master.

[myronmarston]

Thanks, @soulcutter!