controller specs: params hash does not contain :action or :controller

[krisb]

I'm using CanCan for authorisation and it relies on params[:action] and params[:controller] to determine what resource to load for authorisation checks in a before filter. The specs work when CanCan is disabled so the routing etc is all correct.

The spec is:

describe "GET 'new'" do
  it "should be successful" do
    get 'new'
    response.should be_success
  end
end

I can see that the params hash is empty within the action method which is wrong as it should have the action and controller entries. I can work around this by modifying the spec for now, i.e.:
describe "GET 'new'" do
it "should be successful" do
get 'new', { :action => :new, :controller => :users }
response.should be_success
end
end

I suspect this is due to the usage of ActionDispatch::Integration as you mention on similar issues (http://rspec.lighthouseapp.com/projects/5645/tickets/963-request-is-nil and http://github.com/rspec/rspec-rails/issues#issue/10).

[iain]

+1 it also makes this impossible to test pages that use a hash as link_to options or use url_for.

On second thought: that might be related, but not exactly the same, because the workaround doesn't work for the cases I described.

In my case:

# in view:
link_to "English", :locale => :en
# in spec:
get :index, :controller => :teams, :action => :index
# the error:
No route matches {:locale=>:en}

Works fine in browser and test/unit functional tests.

[dchelimsky]

Fixed in http://github.com/rspec/rspec-rails/commit/5ec35fdfddda59afe3422991093088a605b2aa11

(released in 2.0.0.beta.8)

[iain]

fantastic, you rock! :)

[dchelimsky]

@iain - can you verify you're seeing the correct behaviour now?

[iain]

It works (Rails 3.0.0.beta3 and Rspec 2.0.0.beta.8). But now some other interesting things happen, for which I'll open new issues.