undefined method `visit' for #<RSpec::Core::ExampleGroup:....

[be9]

I'm having trouble with my Capybara integration specs and rspec-rails 2.6.0.rc4.

  9) My profile should show profile
     Failure/Error: login_as @user
     undefined method `visit' for #<RSpec::Core::ExampleGroup::Nested_4:0x748aab0>
     # ./spec/support/request_helpers.rb:8:in `login_as'
     # ./spec/integration/user/profile_spec.rb:6

It's simple visit '/' which explodes.

2.6.0.rc2 works great. What has been changed? Capybara version is 1.0.0.beta1

[dchelimsky]

rc4 adds more support for Capybara 0.4 and 1.0. How/where are you requiring capybara?

[be9]

I have require 'capybara/rspec' line in spec/support/additional_requires.rb

[dchelimsky]

Try getting rid of that and tell me what happens. rspec-rails already does this, so it might be that doing it a second time is causing a problem due to module reloading, etc.

[be9]

I've commented out the require line, but nothing changed. visit is still broken.

[dchelimsky]

What's in your Gemfile?

[be9]

Posted Gemfile here: https://gist.github.com/952141

[dchelimsky]

I just ran this: https://gist.github.com/952630 and the spec with visit in it passed. Do you get the same result from that gist?

[be9]

Works here too. I tried to make visit explode by copying in Gemfile and other stuff from my project but it still passes.

On the other side, I experimented with rspec-rails git and found out that this commit exactly: 59793dc breaks things for me (the specs pass with the preceding one when rspec-rails is pulled from git).

[be9]

The test example works if I manually add include Capybara::DSL.

How come it doesn't get included?

[be9]

So, I found it. The example that also breaks for your example app:

require "spec_helper"
describe "things" do
    it "works with visit" do
      go_things
      page.status_code.should eq(200)
    end
end

The cause of the bug is as follows. If we look at the :include_or_extend_modules array in rspec configuration, we see following:

   [[:extend, RSpec::Matchers::DSL, {}],
     [:include, RSpec::Rails::FixtureSupport, {}],
     [:include, RSpec::Rails::Mocks, {}],
     [:include, Capybara::Features, {:capybara_feature=>true}],
     [:include, Capybara::DSL, {:type=>:request}],
     [:include, Capybara::DSL, {:type=>:acceptance}],
     [:include, Capybara::RSpecMatchers, {:type=>:request}],
     [:include, Capybara::RSpecMatchers, {:type=>:acceptance}],
     [:include,
      RSpec::Rails::ControllerExampleGroup,
      {:type=>:controller,
       :example_group=>{:file_path=>/spec[\\\/]controllers/}}],
     [:include,
      RSpec::Rails::HelperExampleGroup,
      {:type=>:helper, :example_group=>{:file_path=>/spec[\\\/]helpers/}}],
     [:include,
      RSpec::Rails::MailerExampleGroup,
      {:type=>:mailer, :example_group=>{:file_path=>/spec[\\\/]mailers/}}],
     [:include,
      RSpec::Rails::ModelExampleGroup,
      {:type=>:model, :example_group=>{:file_path=>/spec[\\\/]models/}}],
     [:include,
      RSpec::Rails::RequestExampleGroup,
      {:type=>:request,
       :example_group=>{:file_path=>/spec[\\\/](requests|integration)/}}],
     [:include,
      RSpec::Rails::RoutingExampleGroup,
      {:type=>:routing, :example_group=>{:file_path=>/spec[\\\/]routing/}}],
     [:include,
      RSpec::Rails::ViewExampleGroup,
      {:type=>:view, :example_group=>{:file_path=>/spec[\\\/]views/}}],
     [:include, Devise::TestHelpers, {:type=>:controller}],
     [:include, RequestHelpers, {:type=>:request}],
     [:include, GlobalSpecHelpers, {}]]}>

(that's from my project). So Capybara::DSL gets included before RSpec::Rails::RequestExampleGroup. The former has :type => :request filter, but the type itself is set when the latter is included. So Capybara::DSL module is rejected by the filter and not included.

In your test example, with double describe block, module inclusion occurs twice. The second time type is already set, Capybara::DSL gets included, everything works.

The fix should be darn simple (haven't got more time right now, but I'll come up with it in the case you don't fix it first :)

[be9]

Fix is available as pull request #362

[tommysqueak]

I've got the same isssue (undefined method `visit' etc). I'm using capybara 1.0.0.beta1 I've got the rspec-rails and dependencies in my gemfile pointing to github. So I would have thought I'd have the latest, which includes the above commit? I have require 'rspec/rails' in my spec_helper.rb. It's in a new project I'm just getting started with. I'm also just getting started with rails, so I'm totally lost. Any help would be much appreciated.

[jackkinsella]

I ran into the same problem today with rspec-rails 2.6.1 and capybara 1.0.0

#spec_helper.rb

require 'rubygems'
require 'spork'
require "email_spec"
ENV["RAILS_ENV"] ||= 'test'     
Spork.prefork do
  require File.expand_path("../../config/environment", __FILE__)
  require 'rspec/rails'
  Dir[Rails.root.join("spec/support/**/*.rb")].each {|f| require f}
end
Spork.each_run do
  Dir[Rails.root.join("site/app/**/*.rb")].each {|f| require f}     
  require "#{Rails.root}/spec/factories.rb"
end