Anonymous controller problem

[Exoth]

I've got such a before_filter in ApplicationController:

def foo
  redirect_to(params.except(:ref, :marker), status: 301) if params[:ref] || params[:marker]
end

And I want to test it using anonymous controller like this:

require 'spec_helper'

describe ApplicationController, type: :controller do
  controller do
    def index
      head :ok
    end
  end

  it "should redirect without ref and marker if any of them is given in request" do
    get :index, ref: 1, marker: 2, foo: 3
    response.should redirect_to('/anonymous/?foo=3')
  end
end

But this results in "was a redirect to http://test.host/flights/?controller=anonymous&foo=3" as inside ApplicationController it continues to use usual routing of the application where anonymous controller is not defined.

What is the supposed way to test such before_filters?

[dchelimsky]

Try response.should redirect_to(:controller => 'anonymous' :foo => 3).

See http://rubydoc.info/gems/actionpack/ActionDispatch/Assertions/ResponseAssertions:assert_redirected_to for more info (the redirect_to matcher delegates to this).

[Exoth]

No. The problem is not with what I expect to get but with what I get. It redirects to http://test.host/flights/?controller=anonymous&foo=3 instead of http://test.host/anonymous/?foo=3 as url_for inside of application_controller method uses application routes without anonymous resource defined. "controller" method replaces application routes with anonymous resource routes only for @routes, which is used for rspec get, post methods, but not anywhere in the application itself.

[Exoth]

So redirect_to inside of my spec file works right, but redirect_to inside of my application works wrong.

[Exoth]

Can anyone reopen the issue? The problem is not solved.

[dchelimsky]

@Exoth re-opened. How would you expect this to work?

[Exoth]

"controller" method could also add anonymous resource to main application routing in before block and remove the resource from there in after block. This way such application code is going to function the same way with anonymous resource as with usual resources.

[dchelimsky]

@alindeman @justinko you guys have any thoughts on this?

[justinko]

What do you have in routes.rb to get "anonymous"?

[Exoth]

Not sure if I understand the question. The "controller" method has this:

    before do
      @orig_routes, @routes = @routes, ActionDispatch::Routing::RouteSet.new
      @routes.draw { resources :anonymous }
    end

    after do
      @routes, @orig_routes = @orig_routes, nil
    end

So I'm talking about the same "resources :anonymous" to be temporarily added to main application routing.

[kirikak2]

Hello.
I met same problem.
So I solved this problem as follow.

before do
    controller.stub(:_routes).and_return(@routes)
end

I'll cross my fingers for you.

[dchelimsky]

@Exoth would a variation of @kirikak2's solution work for you - where we define _routes on the anonymous controller to return @routes?

[kirikak2]

I wrote simple spec that have failed and fixed examples.

require 'spec_helper'

describe ApplicationController, :type => :controller do
  controller(PagesController) do
    before_filter :redirect_to_index, :only => :show

    def index
      render :text => "index page rendered."
    end

    def show
      render :text => "show page rendered."
    end
  end

  describe "GET show(failed pattern)" do
    it "redirect to index page" do
      get :show, :id => 1
      # failed! because no route match.
      response.should redirect_to(:action => :index)
    end
  end

  describe "GET show(success pattern)" do
    before do
      controller.stub(:_routes).and_return(@routes)
    end

    it "redirect to index page" do
      get :show, :id => 1
      response.should redirect_to(:action => :index)
    end
  end
end

redirect_to_index method is defined at ApplicationController.

def redirect_to_index
  redirect_to(:action => :index)
end

First example is failed, because redirect_to method use RouteSet that return ActionController#_routes.
but AnonymousController#_routes returns empty routes about "anonymous".

So I defined stub at AnonymousControler#_routes to return right route.