Make generated spec/rails_helper.rb file compliant with RuboCop 0.80 #2280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Over in @alphagov, we upgraded to RuboCop 0.80 which includes a new cop - `Lint/NonDeterministicRequireOrder`. This fails when linting this file: ``` spec/rails_helper.rb:20:1: W: Lint/NonDeterministicRequireOrder: Sort files before requiring them. Dir[Rails.root.join("spec/support/**/*.rb")].each { |f| require f } ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 158 files inspected, 1 offense detected ``` - While this is a generated file, [we decided to fix it in our projects anyway](alphagov/contacts-admin@715383a) everywhere we could, and push this fix upstream so that everyone gets it in hopefully a next release of `rspec-rails`. Co-authored-by: Issy Long <issy.long@digital.cabinet-office.gov.uk>
|
Looks like Travis had an issue installing gems on both the JRuby builds. 🤔 |
|
No worries, we'll handle that. |
|
Thanks, Jruby fixed elsewhere. |
|
Thank you! |
JonRowe
added a commit
that referenced
this pull request
Mar 13, 2020
…-rubocop-compliant Make generated spec/rails_helper.rb file compliant with RuboCop 0.80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint/NonDeterministicRequireOrder. This fails when linting this file:rspec-rails.Co-authored-by: Issy Long issy.long@digital.cabinet-office.gov.uk