Skip to content

Conversation

benoittgt
Copy link
Member

This reverts commit 3e4c770.

Do not remove ::ActionDispatch::IntegrationTest::Behavior because this
lead to unwanted behavior like uncleaned queue for
ActionMailer::Base.deliveries between tests.

As suggested in rails/rails#37270 there is
many other way to implement this. At the moment this line seems to be
enough for our case.

Fix: #2290

Related:

This reverts commit 3e4c770.

Do not remove ::ActionDispatch::IntegrationTest::Behavior because this
lead to unwanted behavior like uncleaned queue for
ActionMailer::Base.deliveries between tests.

As suggested in rails/rails#37270 there is
many other way to implement this. At the moment this line seems to be
enough for our case.

Fix: #2290

Related:
  - rails/rails#37270
@pirj
Copy link
Member

pirj commented Mar 18, 2020

Looks good. JRuby failure seems unrelated (rubocop).
@cunknown does this fix work for you?

@pirj
Copy link
Member

pirj commented Mar 18, 2020

Filed jruby/jruby#6125


before do
@routes = ::Rails.application.routes
ActiveJob::Base.disable_test_adapter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really unsure about this, why are we doing it? We need to be able to change adapters sure, but surely the default should be the test adapter...

@benoittgt benoittgt closed this Mar 20, 2020
@JonRowe JonRowe deleted the fix-2290 branch March 20, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible regression 4.0.0.beta4 to 4.0.0.rc1: List of ActionMailer deliveries is not cleared between specs

3 participants