Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kwargs usage for Ruby 2.7 #2302

Merged

Conversation

@aubinlrx
Copy link

aubinlrx commented Mar 26, 2020

Summary

Ruby 2.7 displays warning without separation of positional and keyword arguments. This PR intend to fix it when calling the method driven_by.

rspec-rails-4.0.0/lib/rspec/rails/example/system_example_group.rb:100: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
rails-8aa14248a74c/actionpack/lib/action_dispatch/system_test_case.rb:167: warning: The called method `driven_by' is defined here
@pirj
pirj approved these changes Mar 26, 2020
Copy link
Member

pirj left a comment

Looks good, thanks.

@JonRowe
Copy link
Member

JonRowe commented Mar 26, 2020

Hurrah an easy Ruby 2.7 fix 😂

@JonRowe JonRowe merged commit d3d8555 into rspec:4-0-maintenance Mar 26, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@JonRowe
Copy link
Member

JonRowe commented Mar 26, 2020

Thanks 💚 💙 💜 💛 ❤️

JonRowe added a commit that referenced this pull request Mar 26, 2020
JonRowe added a commit that referenced this pull request Mar 26, 2020
JonRowe added a commit that referenced this pull request Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.