Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RSpec gem versions #2574

Merged
merged 3 commits into from
Feb 15, 2022
Merged

Update RSpec gem versions #2574

merged 3 commits into from
Feb 15, 2022

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Feb 14, 2022

No description provided.

@pirj
Copy link
Member

pirj commented Feb 15, 2022

Does it make sense to remove Rails 5 from the matrix? Will we still support it in rspec-rails 6?

[rspec-rails 5.x](https://github.com/rspec/rspec-rails/tree/5-0-maintenance) for Rails 6.x.
[rspec-rails 4.x](https://github.com/rspec/rspec-rails/tree/4-1-maintenance) for Rails from 5.x or 6.x.

@pirj
Copy link
Member

pirj commented Feb 15, 2022

The error seems to come from rack

rack-2.1.4/lib/rack/media_type.rb:18: warning: `&' interpreted as argument prefix

Wondering if this controversial commit that is both "Cleanups since master is 2.3+" and "Cleanups since master is 2.2+". The gemspec says >= 2.3.0.

@JonRowe JonRowe force-pushed the update-rspec-versions branch 4 times, most recently from 05b8ff9 to 7f3584d Compare February 15, 2022 18:25
@JonRowe
Copy link
Member Author

JonRowe commented Feb 15, 2022

@pirj the Rack one is just a warning where as the change that broke the build has a PR open to fix rails/rails#44435

@JonRowe JonRowe force-pushed the update-rspec-versions branch 5 times, most recently from db695f4 to 344865f Compare February 15, 2022 21:48
Gemfile-rails-dependencies Outdated Show resolved Hide resolved
@JonRowe JonRowe merged commit b4f58f4 into main Feb 15, 2022
@JonRowe JonRowe deleted the update-rspec-versions branch February 15, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants