Allow routing specs to access engine routes

[alindeman]

I have a Rails Engine with routes defined in my app.
After upgrade all routing tests fail with No route matches...

I was trying to debug the MyEngine::Engine.routes.router and here's the diff
On latest rspec-rails @ast is always nil.

@@ -1,13 +1,14 @@
 pry(#<RSpec::Core::ExampleGroup::Nested_14::Nested_1>)> @routes.router
-=> #<Journey::Router:0xa1eb388
+=> #<Journey::Router:0xa4e6150
  @options=
   {:parameters_key=>"action_dispatch.request.path_parameters",
    :request_class=>ActionDispatch::Request},
  @params_key="action_dispatch.request.path_parameters",
  @request_class=ActionDispatch::Request,
  @routes=
-  #<Journey::Routes:0xa1eb3ec
-   @ast=nil,
+  #<Journey::Routes:0xa4e61b4
+   @ast=
+    /signup(.:format)|/login(.:format)|/logout(.:format)|/signup(.:format)|/login(.:format)|/start(.:format)|/start(.:format)|/sessions(.:format)|/sessions/new(.:format)|/sessions/:id(.:format)|/passwords(.:form
    @named_routes=
     {"signup"=>
-      #<Journey::Route:0xc685004
\ No newline at end of file
+      #<Journey::Route:0xa6d40c0
\ No newline at end of file

[alindeman]

Thanks for the report! Could you create a small Rails app that demonstrates the problem and push it up to GitHub? I'm not able to figure out what's going on with just the details so far.

[stas]

Here's an example application:
https://github.com/stas/rspec-rails-668

master should be green, rspec_rails_2.12.1 fails for me. The only diff is the rspec-rails gem version.

Thank you for taking a look.

[alindeman]

The repo is incredibly helpful, thank you. I'm digging into the issue now.

[alindeman]

I'm working on this, but it's unlikely to continue working by setting @routes. I hope to have a good solution for this by the next release.

[alindeman]

A workaround for now is:

before do
  assertion_instance.instance_variable_set(:@routes, @routes)
end

I know this sucks, but we're in a hard spot trying to support this alongside Rails 4. I'm working on it soon :)

[stas]

Thanks,
looking forward for the fix.

[gemyago]

+1

[alindeman]

@stas, @evgeny-myasishchev: would you look at my proposed solution, try it out, and give feedback? The branch name is routing_specs_can_set_routes and the docs are here: https://github.com/rspec/rspec-rails/pull/668/files#L0L-1

[gemyago]

Just tried, works great!

[stas]

[alindeman]

Merged. It will appear in rspec-rails 2.14. You can pin to a git revision in the time being, but hopefully it won't be terribly long before another release :)

[stas]

Thank you.

[gemyago]

Great, thanks a lot! :)

[tvdeyen]

Thank you so much for fixing this. ❤️ ❤️
It works like charm.

Thanks 👏