Default infer_base_class_for_anonymous_controllers to true #893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For RSpec 3 this option should now default to true. Updated the config value setting and the spec_helper generator template to instead indicate the default value with the line to set it commented out. Fixes rspec#869
|
Should I also port this to 2.99? |
|
No, 2.99 must behave as 2.14. You would need to port a deprecation warning for when someone uses the old behaviour though. |
|
Also was there some background discussion to changing this for 3.0? I'm not familiar enough with this, I leave this to @alindeman to sort out though. |
ghost
assigned
|
The original discussion resides around #421 (comment) This looks good! Since I think it's pretty much always what folks want (though it was technically a breaking change in 2.x), I am thinking about removing it from the generated |
alindeman
added a commit
that referenced
this pull request
Dec 27, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For RSpec 3 this option should now default to true. Updated
the config value setting and the spec_helper generator template
to instead indicate the default value with the line to set it
commented out.
Fixes #869