New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default infer_base_class_for_anonymous_controllers to true #893

Merged
merged 1 commit into from Dec 27, 2013

Conversation

Projects
None yet
3 participants
@thomas-holmes
Member

thomas-holmes commented Dec 24, 2013

For RSpec 3 this option should now default to true. Updated
the config value setting and the spec_helper generator template
to instead indicate the default value with the line to set it
commented out.

Fixes #869

Thomas Holmes
Default infer_base_class_for_anonymous_controllers to true
For RSpec 3 this option should now default to true. Updated
the config value setting and the spec_helper generator template
to instead indicate the default value with the line to set it
commented out.

Fixes #869
@thomas-holmes

This comment has been minimized.

Member

thomas-holmes commented Dec 24, 2013

Should I also port this to 2.99?

@JonRowe

This comment has been minimized.

Member

JonRowe commented Dec 25, 2013

No, 2.99 must behave as 2.14. You would need to port a deprecation warning for when someone uses the old behaviour though.

@JonRowe

This comment has been minimized.

Member

JonRowe commented Dec 25, 2013

Also was there some background discussion to changing this for 3.0? I'm not familiar enough with this, I leave this to @alindeman to sort out though.

@ghost ghost assigned alindeman Dec 25, 2013

@alindeman

This comment has been minimized.

Contributor

alindeman commented Dec 27, 2013

The original discussion resides around #421 (comment)

This looks good! Since I think it's pretty much always what folks want (though it was technically a breaking change in 2.x), I am thinking about removing it from the generated spec_helper.rb too. Thoughts?

alindeman added a commit that referenced this pull request Dec 27, 2013

@alindeman alindeman merged commit 39b1d43 into rspec:master Dec 27, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment