Fix the missing parenthesis in f-string #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaraco
referenced
this pull request
Jul 31, 2024
The [Python documentation](https://docs.python.org/3/library/stdtypes.html#printf-style-string-formatting) notes that using the `%` operator to format strings can lead to 'a variety of quirks that lead to a number of common errors'. Python added f-strings in version 3.6, with PEP 498. F-strings are a flexible and powerful way to format strings. They make the code shorter and more readable, since the code now looks more like the output. These are also performance benefits to using f-strings as they require the interpreter to only parse the string once rather than backtracking for insertions, requiring multiple parses of the string. As this library only supports Python 3.7+, there is no compatibility concerns. https://github.com/rspeer/ordered-set/blob/master/pyproject.toml#L24
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the previous commits removed the closing parenthesis inside one of f-strings. I fixed it.