Update gitbook and bs4_book templates to use latest version of MathJax 2.7 from cdnjs #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihui
approved these changes
Jun 30, 2022
|
|
|
Hi @yihui : I've resolved that issue. File mode should be 644 again (and I've updated my git config to prevent that from happening in the future) |
yihui
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
Great! We will use https://mathjax.rstudio.com/latest/ again once if actually points to the latest 2.x version. Thank you very much!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the changes discussed in #1354 by updating the source for MathJax in inst/templates/bs4_book.html and inst/templates/github.html to use cloudflare's cdnjs latest for 2.7. This closes an XSS vulnerability (CVE-2018-1999024) found in versions of MathJax in version's earlier than 2.7.4.
I tested this using a couple of input files I had lying around and I can confirm that the version is now MathJax 2.7.9 and that latex is rendering correctly. I did not see an explicit test for math in the test folder. I'd be happy to add one, but not sure I'll get to it today.