Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Chinese translation #681

Merged
merged 6 commits into from
Apr 21, 2022
Merged

Add Chinese translation #681

merged 6 commits into from
Apr 21, 2022

Conversation

shalom-lab
Copy link
Contributor

@shalom-lab shalom-lab commented Mar 24, 2022 •
edited
Loading

Add Chinese translation

  • Sign CLA
  • Finalize translation
  • Re-document
  • Update NEWS with acknowledgement

@CLAassistant
Copy link

CLAassistant commented Mar 24, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@shalom-lab
Copy link
Contributor Author

Add Chinese translation

gadenbuie
gadenbuie reviewed Mar 28, 2022
View reviewed changes
Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing the translation! There are still a few messages that weren't translated. Do you think it'd be possible to translate these as well? Please let me know if you have any questions about those messages.

@shalom-lab shalom-lab closed this Apr 19, 2022
@shalom-lab shalom-lab reopened this Apr 19, 2022
@shalom-lab
Copy link
Contributor Author

Yeah，I didn't understand some of the message before. Thanks for your reply. According to your tips, I have translated the remaining message now.

@gadenbuie
Copy link
Member

/i18nize

@gadenbuie
Copy link
Member

/document

@gadenbuie gadenbuie merged commit acce7f6 into rstudio:main Apr 21, 2022
@gadenbuie
Copy link
Member

Thank you @shalom-lab!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadenbuie gadenbuie gadenbuie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shalom-lab @CLAassistant @gadenbuie