Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move curl to "Suggests" #776

Merged
merged 6 commits into from
Apr 4, 2023
Merged

Move curl to "Suggests" #776

merged 6 commits into from
Apr 4, 2023

Conversation

rossellhayes
Copy link
Contributor

The curl package is only required to enable external evaluators. Since external evaluators aren't needed for most learnr users, this PR moves curl from "Imports" to "Suggests".

@rossellhayes rossellhayes self-assigned this Apr 3, 2023
gadenbuie
gadenbuie approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@rossellhayes rossellhayes merged commit 1ffad2a into main Apr 4, 2023
@rossellhayes rossellhayes deleted the refactor/suggest-curl branch April 4, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadenbuie gadenbuie gadenbuie approved these changes

Assignees

@rossellhayes rossellhayes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rossellhayes @gadenbuie